-
-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build: Fix DLL generation race condition #9770
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ugly, but I'll take it if it works. I take it you've already tried smaller timeouts (0, 1) and that wasn't enough?
No I didn't try smaller ones, this was the first one I tried, and it worked. Shall I lower this timeout? |
Were you able to repro the problem in the first place? Like I said, I'll take it if it works. But generally speaking the less funky stuff we have in our codebase the better. |
Yes I was able to reproduce. I tested this twice on my local machine. A 5 second delay was arbitrary, testing takes minutes, so after finding that the 5 second timeout worked, I was happy. |
Build: Fix DLL generation race condition
Issue: #9707
What I did
FIX it with some very funk setTimeout